Conversation
When doctor runs on protected main, sandbox auto-finish can return success while leaving the PR open due branch policy. The CLI previously labeled this as "Auto-finish flow completed", which is misleading and caused confusion. This change inspects agent-branch-finish output for pending markers, reports a pending status with PR URL, and adds a regression test for blocked merge policy behavior. Constraint: Keep doctor exit behavior non-fatal when PR is created but merge is pending policy gates Rejected: Force --wait-for-merge for all doctor runs | risks long hangs and timeouts on review-gated repositories Confidence: high Scope-risk: narrow Reversibility: clean Directive: Treat agent-branch-finish pending markers as non-complete states in higher-level status messaging Tested: node --check bin/multiagent-safety.js Tested: node --test test/install.test.js Tested: npm test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated by scripts/agent-branch-finish.sh (PR flow).